🐛 fix(retention): bind plans to one snapshot - #1852
Merged
Merged
Conversation
The planner read retention summaries before driver evaluation. A concurrent metadata commit could pair one frontier with decisions from another snapshot. Drivers pass the snapshot identity through a start callback while the read transaction remains open. The planner checks cursors and writers emit headers from that identity before streaming decisions.
Merging this PR will not alter performance
Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A retention plan could combine a summary read before evaluation with decisions read after a concurrent metadata commit. The cursor or export header could then describe a different frontier from its rows.
Drivers open the candidate snapshot, report its identity, then emit decisions. The planner checks cursors and writes headers from that identity, rejects drivers that violate the start protocol, and keeps stale responses ahead of all output.
Closes #1145