🐛 fix(webhooks): preserve events across queue faults - #1853
Closed
gaborbernat wants to merge 1 commit into
Closed
gaborbernat wants to merge 1 commit into
gaborbernat wants to merge 1 commit into
Conversation
Peryx could commit a package mutation before queueing its webhook, so a queue failure discarded the only delivery state. Persist each event intent in the mutation transaction and give its target deliveries fixed identities. The worker resumes missing targets after restart and leaves committed delivery rows intact. Closes tox-dev#1476
Member
Author
|
Replaced by #1854 so the branch lives in tox-dev/peryx. |
Merging this PR will not alter performance
Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A committed PyPI or OCI mutation could lose its webhook when the first or a later target queue write failed, leaving no durable work for restart recovery.
Peryx now commits each webhook intent with its mutation, including a fixed target snapshot and delivery identities. The background worker writes missing target rows and retains the intent until fan-out completes, so restart recovery leaves existing rows intact.
Closes #1476