🐛 fix(auth): bind OIDC callbacks to providers - #1855
Merged
Merged
Conversation
The callback accepted an OIDC handoff on any configured provider route because the sealed state lacked an issuer binding. A second provider could exchange the browser verifier and nonce. Bind each handoff to its provider and reject mismatches before provider traffic. Clear rejected and legacy cookies to prevent reuse on another route.
Merging this PR will not alter performance
Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sealed OIDC handoff omitted its provider, so a browser could present that handoff to another configured provider route in violation of RFC 9700 section 4.4.
Peryx seals the provider ID with each pending login and checks it before discovery or token exchange. Provider mismatches and legacy handoffs without an ID return the existing bad-request response and clear
peryx_login; matching single- and multi-provider callbacks retain their session flow.Closes #1535