🐛 fix(metrics): commit snapshots in one transaction - #1856
Merged
Merged
Conversation
Peryx used separate redb commits for lifetime totals and daily buckets. A failure between commits left the snapshots at different event frontiers. Use one redb write transaction for both snapshots and one read transaction when loading them. Keep a failed checkpoint pending for the next flush. Refs #1403
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Peryx committed lifetime totals before daily buckets. A storage failure between those commits produced snapshots from different event frontiers, which a restart loaded as one state.
The metrics store accepts each pair as one checkpoint. Peryx commits both keys in one
redbwrite transaction and loads them through oneredbsnapshot read. The aggregator keeps a failed checkpoint pending for the next flush.Closes #1403