🐛 fix(web): expose loader failures - #1860
Merged
Merged
Conversation
gaborbernat
added
bug
Merging this PR will not alter performance
Comparing 
Footnotes
|
Deserialize browser responses into strict endpoint wire types so malformed or failed requests cannot become valid empty UI models. Keep the last loaded data visible while displaying the bounded loader error. Refs #1358
CI caught six untested error-formatting lines and one retained-state branch. The missing cases left the refresh failure contract unverified in native builds. Table-driven message cases cover each error kind. A state transition test verifies that a failed refresh reports the error while preserving the prior value.
gaborbernat
force-pushed
the
fix/web-loader-errors-1358
branch
from
August 30, 2026 06:58
41d1727 to
733f649
Compare
Documentation build overview
35 files changed ·
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browser loaders treated transport failures or invalid payloads as valid empty models. 🌐 The UI then discarded the last valid view and could display a failing endpoint's response body.
The browser loader deserializes each endpoint into its own wire type and returns a bounded typed error without reading the response body. A failed refresh keeps the last valid model visible; the next valid response clears the error and replaces it.
Closes #1358