🐛 fix(auth): bound password derivations - #1863
Merged
Merged
Conversation
Reject password work before hashing when the process-wide active and waiting capacity is full. Propagate overloads as service unavailable without distinguishing real users from decoys. Refs #1466
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Argon2 work now uses one process-wide admission budget for running and queued derivations. Requests beyond the fixed four-active/four-waiting bound fail before identity lookup or hashing, while a canceled queued request releases its slot and a canceled running request remains charged until blocking work exits.
Every password-derived operation shares the same path, including decoys and stale-verifier upgrades. Public HTTP and distributed callers return service unavailable without exposing whether an account exists.
Closes #1466