🐛 fix(replication): enforce batch budgets - #1871
Merged
Merged
Conversation
A drain could retain more changes than its caller's budget because each request used the configured page size. HTTP frames replaced the received byte length with a compact re-encoding. Cap each request by the remaining slots and reject an oversized count before extending the retained batch. Keep the bounded response length so whitespace and exact byte limits remain part of the transport contract.
Merging this PR will not alter performance
Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A peer could return a full page when a replication drain had one budget slot left. The drain retained the full page, and the HTTP transport reported a compact re-encoding size instead of the received body length. Insignificant JSON whitespace disappeared from frame accounting.
The drain caps each request at its remaining slots and rejects an over-count page before adding changes to the result. The HTTP transport enforces the same count bound after decoding and records the bounded wire length. The streaming cap still rejects a body before JSON decoding when it crosses the byte limit. 📦
Closes #1139