🐛 fix(test): serialize external reaping - #1872
Merged
Merged
Conversation
The startup owner and the external reap fixture could both wait for the same process, so either thread could consume its exit status. Transfer the capture descriptors to the test before the fixture exits. The test owns waitpid and releases those descriptors after reaping the process. The startup owner then receives ECHILD through the intended error path. Refs #1864
Merging this PR will not alter performance
Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The toxiproxy external-reap fixture allowed its startup owner and helper to wait for the same child, so either thread could consume the exit status. The resulting ECHILD race failed the macOS platform lane on
main.The fixture now exits with a zero status after transferring its captured output descriptors through a Unix socket. The external reaper owns
waitpid, then releases the transferredOwnedFdvalues so startup receives ECHILD through its public error path. Exact descriptor-count handling closes every received descriptor on failure. 🔒Closes #1864