馃懛 ci: derive the wheel toolchain from rust-toolchain.toml - #689
Merged
gaborbernat merged 2 commits intoAug 23, 2026
Conversation
The channel and components were written twice, and the comment asked whoever edited one to remember the other. Dependabot owns rust-toolchain.toml and cannot reach the workflow, so its bump to 1.98 left the pin at 1.97; the container then provisioned 1.98 on demand during the parallel build and the aarch64 musl wheel failed on a half-installed toolchain. Reading the file at build time removes the pair that can disagree.
The Windows wheel jobs run steps through PowerShell, which rejects the heredoc. Resolve the version already names bash for the same reason.
gaborbernat
force-pushed
the
rust-toolchain-single-source
branch
from
August 23, 2026 19:52
bb08cbb to
546326a
Compare
gaborbernat
enabled auto-merge (squash)
August 23, 2026 19:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wheel build pins the Rust channel and components in
CIBW_BEFORE_ALL_LINUX, andrust-toolchain.tomlstates them again; the comment above the pin asks whoever edits one to keep the other in sync. Dependabot owns the toml file and cannot reach the workflow, so #686 moved the channel to 1.98 while the pin stayed at 1.97. Each container then provisioned 1.98 on demand during the parallel ninja build, raced, and the aarch64 musl wheel died withrecovering from a partially installed toolchainthendetected conflict: 'bin/cargo-clippy'. 馃懛A step now reads
rust-toolchain.tomland hands rustup the flags, so the two cannot disagree and the next toolchain bump needs no workflow edit. Running the step as GitHub composes it emitsflags=--default-toolchain 1.97 --component clippy --component llvm-tools-preview --component rustfmt.