fix: resolve PUBLIC before looking up the user home - #546
Open
emme1t wants to merge 3 commits into
Open
Conversation
emme1t
marked this pull request as ready for review
September 12, 2026 06:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows().user_publicshare_dirraisesRuntimeError: Could not determine home directorywhenPUBLICis set but the home-directory environment variables are unavailable. The default argument toos.environ.get()evaluatesPath("~").expanduser()before the environment lookup returns.Resolve the home-based fallback only when
PUBLICis absent. Existing normalization, fallback paths, and empty-string behavior are preserved. Add regressions for an unavailable home with an explicit public path and for the fallback whenPUBLICis absent, plus a news fragment.Reproduced on Windows with Python 3.13:
Before the fix this raises
RuntimeError; afterward it returnsC:\Users\Shared.Validation:
tox r: Python 3.12 and 3.13 each pass 1,243 tests with 94 skips. Other configured interpreters are unavailable locally and skipped by tox.git diff --checkpasses.Prepared with OpenAI Codex assistance. The reproduction and checks above were executed locally, and the patch received an independent agent review.