Skip to content

Enable minimal testing with windows and macOS - #215

Merged
gaborbernat merged 1 commit into
tox-dev:mainfrom
ssbarnea:chore/test-os
Aug 7, 2025
Merged

gaborbernat merged 1 commit into
tox-dev:mainfrom
ssbarnea:chore/test-os

Conversation

@ssbarnea

@ssbarnea ssbarnea commented Jun 20, 2025

Copy link
Copy Markdown
Contributor

Due to the specific nature of how uv works, some minimal testing on Windows and MacOS would be needed.

Related: #193 #183
Related: astral-sh/uv#14239

@ssbarnea

ssbarnea commented Jun 20, 2025

Copy link
Copy Markdown
Contributor Author

@gaborbernat I am unable to test this change because I cannot create branches in tox-uv itself and GHA pipeline changes run only on local PRs, not the ones from forks. Can you please give a hand with this? Thanks.

Here is PR I made with the same code on my branch https://github.com/ssbarnea/tox-uv/actions/runs/15777559807/job/44475364088?pr=2

If you want I can remove the pull_request_target from it. As you can see we have 3 broken Windows tests, which proves the need for platform testing. As a first stage I would probably add a conditional xfail to them to allow the testing to be abled, and fix them after. Sounds ok to you?

@ssbarnea
ssbarnea force-pushed the chore/test-os branch 5 times, most recently from 50f9a8f to a8f17ea Compare June 20, 2025 11:06
@gaborbernat

Copy link
Copy Markdown
Member

If you want I can remove the pull_request_target from it. As you can see we have 3 broken Windows tests, which proves the need for platform testing. As a first stage I would probably add a conditional xfail to them to allow the testing to be abled, and fix them after. Sounds ok to you?

Ok.

@ssbarnea
ssbarnea force-pushed the chore/test-os branch 5 times, most recently from 87fcab2 to 352ef5e Compare June 24, 2025 11:55
@ssbarnea ssbarnea changed the title Enable minimal testing with windows and ubuntu Enable minimal testing with windows and macOS Jun 24, 2025
@ssbarnea
ssbarnea force-pushed the chore/test-os branch 7 times, most recently from 1e15c31 to 1151573 Compare June 25, 2025 07:29
@ssbarnea
ssbarnea marked this pull request as ready for review June 25, 2025 07:34
@ssbarnea
ssbarnea requested a review from gaborbernat as a code owner June 25, 2025 07:34
@ssbarnea

Copy link
Copy Markdown
Contributor Author

@gaborbernat I finally made it pass CI. I had to use "xfail" on some broken tests as they are not fixable by us. I fixed few minor issues with existing ones. Once this goes in we will be able to gradually address these bugs.

Please let me know what I need to change to close this one. Thanks.

Comment thread tests/test_tox_uv_venv.py
Due to the specific nature of how uv works, some minimal testing on
Windows and MacOS would be needed.

Related: tox-dev#193 tox-dev#183
@gaborbernat
gaborbernat enabled auto-merge (squash) August 7, 2025 14:56
@gaborbernat
gaborbernat disabled auto-merge August 7, 2025 15:29
@gaborbernat
gaborbernat merged commit bf3b443 into tox-dev:main Aug 7, 2025
12 checks passed
@ssbarnea
ssbarnea deleted the chore/test-os branch August 14, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants