Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Red phase: 4 scenarios for URL input clear button — visibility rules, preview persistence on clear, hidden during loading, and error clearing. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
URL 입력창에 텍스트가 있고 로딩 중이 아닐 때 X(clear) 버튼을 표시한다.
클릭 시 onUrlChange("") 와 onErrorClear()를 호출하여 URL과 에러를 초기화한다.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Extract repeated onUrlChange("") + onErrorClear() pair into handleClear
- Simplify url.length > 0 to truthy url check
- Remove afterEach(vi.restoreAllMocks) — no spyOn in this test file
- Remove inline comments that narrate what assertions already express
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…on feature Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…er alignment Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…lanced spacing Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
bun run test전체 통과🤖 Generated with Claude Code