botの実装をした#35
Open
hachimitsu-pichi wants to merge 9 commits into
Open
Conversation
ramdos0207
requested changes
Jan 12, 2026
ramdos0207
left a comment
ramdos0207
left a comment
Member
There was a problem hiding this comment.
ありがとうございます！2点コメントを付けたので、確認して欲しいです:pray:
| } | ||
|
|
||
| // NotifyTicketCreated : チケット作成通知 | ||
| func (s *Service) NotifyTicketCreated(ctx context.Context, _ string, title string, creatorID string) error { |
Member
There was a problem hiding this comment.
勘違いだったら申し訳ないのですが、これどこからも呼ばれていない気がします（チケットが作成されてもこの関数が呼ばれない）
Member
There was a problem hiding this comment.
ノート作成通知、レビュー作成通知もそれぞれどこからも呼ばれていない（ノート・レビューが作成されてもメッセージが飛ばない）ので修正して欲しいです！
| func (s *Service) SendDeadlineReminder(ctx context.Context, ticketTitle string, daysOverdue int, assigneeID string) error { | ||
| msg := fmt.Sprintf("【期限超過リマインド】\n案件「%s」の期限から %d日 が経過しました。\n対応状況を確認してください。", ticketTitle, daysOverdue) | ||
|
|
||
| if err := s.PostDirectMessage(ctx, assigneeID, msg); err != nil { |
Member
There was a problem hiding this comment.
実は担当者（など）はUUID（2e0c6679-166f-455a-b8b0-35cdfd257256など）ではなく@で始まるID（ramdosなど）が入るので、このままだと多分動きません...
ramdos0207
requested changes
Jan 15, 2026
ramdos0207
left a comment
ramdos0207
left a comment
Member
There was a problem hiding this comment.
3点コメント付けたので、確認して欲しいです！
（その上でコンフリクトを解消してテストを通しておいて欲しいです）
| dueStr = ticket.Due.Time.Format("2006/01/02") | ||
| } | ||
|
|
||
| message := fmt.Sprintf(`## 新しいチケット(ID: %d)が作成されました |
Member
There was a problem hiding this comment.
必ずしもこのPRで直さなくても大丈夫（リリース後の修正で問題ない）のですが、BOTからの通知文面に統一感がない（見出しレベルや、タイトルの太字強調の有無などがまちまちである）のが気になります...！
| } | ||
| }() | ||
|
|
||
| fmt.Println("============ BOT DEBUG START ============") |
hachimitsu-pichi
force-pushed
the
feat/bot
branch
from
8f09dba to
d0c2611
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.