fix: exclude label-blacklisted vaults from APY - #1290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Vault group average APY should exclude blacklisted vaults even when the upstream payload only carries the
Blacklistedrisk label and omits the numeric999sentinel.Lessons learnt
The chains vault page already builds Avg. APY from
calculateTvlWeightedApy()over the eligible vault set. Making the shared blacklist helper accept both blacklist representations keeps chain, protocol, stablecoin and slim-client consumers aligned.Summary
risk: Blacklistedas blacklisted even whenrisk_numericis missing.riskin the slim vault payload keys so label-based checks survive slimming.