Change protocol vault page metadata title to "vaults and yields" - #1291
Merged
Conversation
Updates the shared metadata title template for protocol vault pages from "<Protocol> vault comparison" to "<Protocol> vaults and yields" (e.g. the Ember page now reads "Ember vaults and yields"). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The protocol vault pages (e.g.
/trading-view/vaults/protocols/ember) used the metadata title<Protocol> vault comparison. The desired wording is<Protocol> vaults and yields, which better reflects the page content and improves SEO/social sharing metadata.Lessons learnt
The metadata
titleon[protocol=slug]/+page.svelteis a single shared$derivedtemplate that also feeds the OpenGraph, Twitter, and JSON-Ld tags. Changing it updates the title for every protocol page consistently, not just one protocol.Summary
${protocolName} vault comparisonto${protocolName} vaults and yieldsinsrc/routes/trading-view/vaults/protocols/[protocol=slug]/+page.svelte.