Skip to content

Fix mobile vault external link #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miohtama merged 1 commit into from
Jul 4, 2026
Merged

Fix mobile vault external link #1301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions src/routes/trading-view/vaults/[vault=slug]/VaultPageHeader.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,9 @@
{#snippet cta()}
<span class="cta-actions">
{#if vault.link}
<span class="external-link">
<Button href={vault.link} target="_blank" rel="noreferrer">
View on {externalSiteName}
</Button>
</span>
<Button href={vault.link} target="_blank" rel="noreferrer">
View on {externalSiteName}
</Button>
{/if}
<UpdateInfoButton size="md" />
</span>
Expand All @@ -50,12 +48,6 @@
gap: 0.75rem;
}

.external-link {
@media (--viewport-sm-down) {
display: none;
}
}

.vault-description {
margin: 0;
font: var(--f-ui-lg-roman);
Expand Down
12 changes: 12 additions & 0 deletions tests/integration/trading-view/vaults/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,18 @@ test.describe('vault index page', () => {
await expect(page.locator('.notes')).toHaveCount(0);
});

test('shows the external vault link in the mobile detail header', async ({ page }) => {
await page.setViewportSize({ width: 390, height: 844 });
await page.goto('/trading-view/vaults/morpho-flagged-blacklisted-vault');

const externalVaultLink = page.getByRole('link', { name: 'View on Morpho' });
await expect(externalVaultLink).toBeVisible();
await expect(externalVaultLink).toHaveAttribute(
'href',
'https://app.euler.finance/earn/0xc3415c9231dad88f8146107372143f6dae042967?network=arbitrum'
);
});

test('warns when deposits may be disabled on a vault detail page', async ({ page }) => {
await page.goto('/trading-view/vaults/deposit-disabled-vault');

Expand Down
1 change: 1 addition & 0 deletions tests/mocks/top-vaults/list.mock.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,7 @@ const morphoFlaggedBlacklistedVault = createTestVault('Morpho flagged blackliste
address: '0xc3415c9231dad88f8146107372143f6dae042967',
chain: 'arbitrum',
protocol: 'Morpho',
link: 'https://app.euler.finance/earn/0xc3415c9231dad88f8146107372143f6dae042967?network=arbitrum',
current_nav: 20_000,
peak_nav: 30_000,
risk: 'Blacklisted',
Expand Down
Loading