Fix vault listing filters - #1312
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Vault protocol pages already know the protocol from the route, so showing and applying the Hide unknown protocol checkbox is redundant and can hide the page's own rows. Robinhood chain vault listings also need to show vaults below the usual default TVL threshold.
Lessons learnt
Protocol-specific vault listings should disable protocol-discovery filters at the shared table level so stale URL parameters cannot keep filtering the page after the checkbox is hidden.
Summary
showUnknownFilteroption to the top vaults page and table.anyTVL filter while other chain pages keep10k.