Fix missing fee data in vault returns - #1322
Merged
Merged
Conversation
miohtama
force-pushed
the
fix/vault-rolling-returns-notice
branch
from
July 18, 2026 14:55
f877021 to
81835d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Vaults without onchain fee data cannot calculate net returns. The returns and fees table should state that directly rather than render an empty or misleading value.
Lessons learnt
Fee availability and net-return availability are distinct data states. Keep the unavailable explanation next to the affected cell and constrain the tooltip width for readable scanning.
Summary
No datawith an explanatory tooltip for missing fee values and unavailable net returns.