Fix vault fee display tooltips - #1323
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Vault listing and detail pages needed clearer fee metadata. Group listings with an Avg. APY column now explain that the value is TVL-weighted over the last 30 days. Vault detail fee tables need to display contractual gross fees while keeping net return values sourced from the existing net return data, and internalised-fee vaults need explicit copy explaining why gross and net returns may match.
Lessons learnt
Internalised vault fees can already be reflected in the share price data, so the frontend should not infer a fee adjustment from the displayed contractual fee. The UI needs to distinguish display-only gross fee schedules from net return fields supplied by the vault dataset.
Summary