Improve tokenised funds chart labels - #1324
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The tokenised funds chart became hard to scan as more funds were added. It needed a predictable seven-entry breakdown plus an Other slice, curator logos on desktop labels, and a cleaner mobile layout without rounded label boxes or logos.
Lessons learnt
ECharts rich label images work well for desktop curator branding, but mobile labels need to stay text-only to fit all chart slices cleanly. The shared market-share helper also needs an explicit standalone slice limit instead of relying only on percentage thresholds.
Summary