Sanitize environment in package_with_root#1671
Merged
Merged
Conversation
smoelius
force-pushed
the
sanitize-environment-in-package_with_root
branch
12 times, most recently
from
June 9, 2025 22:41
bbac75e to
44ff53e
Compare
smoelius
enabled auto-merge
June 9, 2025 22:42
smoelius
force-pushed
the
sanitize-environment-in-package_with_root
branch
from
June 9, 2025 22:51
44ff53e to
477bac6
Compare
smoelius
force-pushed
the
sanitize-environment-in-package_with_root
branch
from
June 9, 2025 22:53
477bac6 to
e837eb8
Compare
Collaborator
Author
|
Thanks to @fcasal for providing the repo that demonstrated this bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A problem arises when the linted project uses edition 2021 but the lints uses edition 2024.
If the environment is not sanitized, the edition 2021 tools are propagated to the lints via environment variables, and the lints fail to build. What's more, the errors are suppressed, and the generic "No libraries were found." is printed.
This change needs a test.