feat(ipinfo): accept multiple fields#639
Merged
Merged
Conversation
ce4b7bc to
9773d8a
Compare
9773d8a to
b57852f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--ipinfofield lists such as--ipinfo 0,1y/zcycling compatible by collapsing back to a single selected fieldipinfoparser errors instead of a generic invalid argumentFixes #201.
Inspired by the multiple-ipinfo behavior shown by yvs2014 in https://github.com/yvs2014/mtr085. This is a fresh implementation for the current upstream
ui/asn.ccode path rather than a cherry-pick from that fork.Tests
git diff --checkmake -j$(nproc)sudo python3 ./test/cmdparse.py./mtr --ipinfo 0,1 --help./mtr --ipinfo 0,,1 --helpexits non-zero with an ipinfo parser error./mtr --ipinfo 0,x --helpexits non-zero with an ipinfo parser error