Refactor group nav to reuse fetched group data - #10150
Conversation
nopcoder
added
the
include-changelog
|
|
||
| if (loading) return <Loading />; | ||
|
|
||
| const resolvedGroupId = response?.id || groupId; |
There was a problem hiding this comment.
Note that when running lakeFS locally, I saw this response:
And in the cloud:
In the cloud, the group name is different from the group ID for each group.
So I think we should check:
const resolvedGroupId = response?.name || response?.id || groupId;
There was a problem hiding this comment.
@Annaseli How did you retrieve the data from the cloud? Did you update the lakefs image and obtain this information?
There was a problem hiding this comment.
The the PR I'm fetching the group ID that in the claude is resolved to the group name.
There was a problem hiding this comment.
I didn't do anything special, I just logged in to the treeverse org and saw this output on this page:
https://treeverse.us-east-1.lakefscloud.io/auth/groups
There was a problem hiding this comment.
The the PR I'm fetching the group ID that in the claude is resolved to the group name.
Do you mean that you see the group name is stored in the group ID in the cloud groups?
There was a problem hiding this comment.
check my fix. I'm using the value I return from the call.
Avoid duplicate group fetches and ensure breadcrumbs use the resolved group id.
…tion Display a loading indicator instead of rendering with the raw URL groupId, preventing flicker when the resolved ID differs. Use the original groupId for all navigation links while showing the resolved ID only for display.
1a29b6d to
be5f6bf
Compare
2 participants
Avoid duplicate group fetches and ensure breadcrumbs use the resolved group id.
Note that the current solution will call the backend to resolve the group id to name.
The UI will render the heading with the id first and the real id is fetched and updated while view is rendered.
Closes #10162
Closes https://github.com/treeverse/product/issues/1026
Preview of the end-result