fix(movement bonuses): boats not getting movement bonus when doing multi-leg trips

[DanVanAtta]

Boats with a +1 movement from a harbor needed previously to do all
movement in one go to have that +1 movement bonus. IF the boat goes
on a multi-leg trip, it should still have had that +1 movement.

This update fixes that, so boats with the +1 movement can
do a multi-leg trip and still receive the movement bonus.

Resolves #9584

[Cernelius]

Assuming the correct issue and thus game is being referenced in here (the original Pacific, not the 1940 later one), is it being taken into account that

1. The +1 movement bonus is obtained only if both the starting and the ending sea zones are adjacent to a harbour (naval base).
2. This applies only during Non-Combat Move (not during Combat Move).
3. This applies to the territory option
   https://github.com/triplea-maps/the_pact_of_steel/blob/38788f2f49596bd7ea8c967174015bce0975ee62/map/games/pact_of_steel_2.xml#L2364
   so is a different thing from the harbours of the latest Pacific games and refers primarily to the "pacific" map at https://github.com/triplea-maps/pacific and NOT to the "world war ii pacific" map at https://github.com/triplea-maps/world_war_ii_pacific (and by "map" I mean "each of the games of that map", which is only one in the case of "pacific").
   ?

Just to be sure, are you using the "Pacific" game to test this? If so, the main problem which I see with that is that that game is not actually using the "navalBase" territory option at all, so it cannot be used to test this. I'm asking because the issue you are referencing seems to be talking about this game specifically, based on what has been said and the images which have been posted in there by @Thegoodcaptain.

Regarding point 3, I see that this game incorrectly threats "harbour"
https://github.com/triplea-maps/pacific/blob/7f065f5bfe91ffdaaa44e1c02295be33e886c274/map/games/pacific.xml#L776 just like it works in later pacific games, so I don't think that this map can be fixed properly without also making changes to the game file (XML) of the map.

I've made a search for all "pacific" maps to see which ones of their games are actually using the "navalBase" option so can possibly (I've tested them a little bit.) be used for testing what I'm understanding you are doing. I've only found the following one.
https://github.com/triplea-maps/pacific_1942/blob/master/games/pacific_1942.xml

Long story short: if I'm understanding what we are talking about here, the problem is not primarily at the program level but firstly due to the fact that the "Pacific" map's game file is not coded correctly, so don't use the "Pacific" game (of the "pacific" map) for testing this (unless you modify its game file (XML) first): use instead the "Pacific: 1942" game (of the "pacific_1942" map) (or whatever other game using the "navalBase" territory option).

I urge not merging this until the matter is clarified.

CC:
@Thegoodcaptain
@RogerCooper
@panther2

[Cernelius]

Also, I think that this should not be a release blocker for TripleA 2.8 (I don't know if it is.). I tend to think that it would be actually better tackling this after the release is done if the matter is not very easy to clarify and be done. I think it's important to fix this, but I'm just saying that I wouldn't delay the release for this.