fix(battle): refresh UI step list when firing groups change mid-battle#14402
Open
DanVanAtta wants to merge 2 commits into
Open
fix(battle): refresh UI step list when firing groups change mid-battle#14402DanVanAtta wants to merge 2 commits into
DanVanAtta wants to merge 2 commits into
Conversation
When units die before their phase fires (e.g. offensive AA kills a defender before defensive fire), the engine's firing groups can collapse from multiple groups into fewer. The UI's step list was generated at battle start and wouldn't match, causing a "Could not find step name" warning in BattleStepsPanel. Fix by recomputing and rebroadcasting the step list to the UI whenever a generated step name is missing from it, so the display always reflects what will actually execute. Fixes #11617
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When units die before their phase fires (e.g. offensive AA kills a
defender before defensive fire), the engine's firing groups can collapse
from multiple groups into fewer. The UI's step list was generated at
battle start and wouldn't match, causing a "Could not find step name"
warning in BattleStepsPanel.
Fix by recomputing and rebroadcasting the step list to the UI whenever
a generated step name is missing from it, so the display always reflects
what will actually execute.
Fixes #11617