Fix(Multiplayer): resolve time out waiting for step name to change#14406
Open
DanVanAtta wants to merge 2 commits into
Open
Fix(Multiplayer): resolve time out waiting for step name to change#14406DanVanAtta wants to merge 2 commits into
DanVanAtta wants to merge 2 commits into
Conversation
Currently the server will notify game clients of game step changes. This is very brittle, the notification can be lost, the client has a race condition where it might not start listening to this message in time. The crux though, the client already knows what the next step should be, it does not need the server to tell it. This fix updates that, so the client sets the step name, removing this whole flow where the server is sending the updated step name to client. Fixes #12005
Member
|
@DanVanAtta Are you going to fix this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the server will notify game clients of game step changes.
This is very brittle, the notification can be lost, the client
has a race condition where it might not start listening to this message
in time.
The crux though, the client already knows what the next step should
be, it does not need the server to tell it. This fix updates that,
so the client sets the step name, removing this whole flow where
the server is sending the updated step name to client.
Fixes #12005