Replace bincode with serde-wincode - #694
Open
SebTardif wants to merge 1 commit into
Open
Conversation
Replace the unmaintained bincode crate (RUSTSEC-2025-0141) with serde-wincode, the serde compatibility layer for the wincode crate. wincode is the recommended successor by the bincode maintainers and is byte-compatible with bincode 1.3, so existing .packdump and .themedump files continue to work without regeneration. Closes trishume#606
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the unmaintained
bincodecrate (RUSTSEC-2025-0141) withserde-wincode, the serde compatibility layer forwincode.wincodeis the successor recommended by the bincode maintainers and produces byte-compatible output with bincode 1.3.Since #625 already removed
bincodetypes from the public API, this is a non-breaking internal dependency swap. Existing.packdumpand.themedumpfiles continue to work without regeneration, as confirmed by the existinghas_default_themes,can_dump_and_load, anddump_is_deterministictests.Closes #606