fix: Forward HTTP headers for generate requests#8795
Draft
mudit-eng wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Mudit Aggarwal <mudita@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Forwards matching HTTP headers as inference request parameters in the
/generateand/generate_streamHTTP paths by calling the sameForwardHeadershelper used by/infer.Adds a generate endpoint regression using an ensemble that routes to the Python backend and verifies a forwarded HTTP header is visible through
request.parameters().Checklist
<commit_type>: <Title>Commit Type:
Related PRs:
None.
Where should the reviewer start?
src/http_server.cc, thenqa/L0_http/generate_endpoint_test.py.Test plan:
git diff --check HEAD~1..HEADpython3 -m py_compile qa/L0_http/generate_endpoint_test.py qa/python_models/generate_models/mock_llm/1/model.pyqa/L0_http/test.shgenerate endpoint section (not run locally:/opt/tritonserver/bin/tritonserveris not present in this environment)CI Pipeline ID:
N/A
Caveats:
Local end-to-end QA could not be run because this environment does not include the Triton server runtime binary.
Background
Linear issue TGH-116 reported that
--http-header-forward-patternworked for/inferbut not/generatewhen routing from an ensemble to the Python backend.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Linear Issue: TGH-116