Skip to content

test: Simplify BF16 triton dtype selection in identity_test#8846

Merged
yinggeh merged 2 commits into
mainfrom
yinggeh/tri-1374-fix-ci-test-l0_backend_identity-base
Jun 22, 2026
Merged

test: Simplify BF16 triton dtype selection in identity_test#8846
yinggeh merged 2 commits into
mainfrom
yinggeh/tri-1374-fix-ci-test-l0_backend_identity-base

Conversation

@yinggeh

@yinggeh yinggeh commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

What does the PR do?

Removes the identity_bf16 special-case when choosing the Triton input datatype in identity_test.py. Since np_to_triton_dtype(ml_dtypes.bfloat16) == "BF16", a single triton_type = np_to_triton_dtype(input_data.dtype) covers every model, including BF16.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.

Commit Type:

  • test

Where should the reviewer start?

qa/L0_backend_identity/identity_test.py

Test plan:

Exercised by L0_backend_identity.

  • CI Pipeline ID: 55062265

Caveats:

Cosmetic cleanup; no behavior change (the explicit "BF16" string and np_to_triton_dtype(ml_dtypes.bfloat16) resolve to the same datatype).

Signed-off-by: Yingge He <yinggeh@nvidia.com>
@yinggeh yinggeh self-assigned this Jun 17, 2026
@yinggeh yinggeh requested review from Vinya567 and whoisj June 17, 2026 01:16
@yinggeh yinggeh added the PR: test Adding missing tests or correcting existing test label Jun 17, 2026
@yinggeh yinggeh merged commit bd5e7dd into main Jun 22, 2026
3 checks passed
@yinggeh yinggeh deleted the yinggeh/tri-1374-fix-ci-test-l0_backend_identity-base branch June 22, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: test Adding missing tests or correcting existing test

Development

Successfully merging this pull request may close these issues.

3 participants