test: Simplify BF16 triton dtype selection in identity_test#8846
Merged
yinggeh merged 2 commits intoJun 22, 2026
Conversation
Signed-off-by: Yingge He <yinggeh@nvidia.com>
Vinya567
approved these changes
Jun 17, 2026
whoisj
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Removes the
identity_bf16special-case when choosing the Triton input datatype inidentity_test.py. Sincenp_to_triton_dtype(ml_dtypes.bfloat16) == "BF16", a singletriton_type = np_to_triton_dtype(input_data.dtype)covers every model, including BF16.Checklist
<commit_type>: <Title>Commit Type:
Where should the reviewer start?
qa/L0_backend_identity/identity_test.pyTest plan:
Exercised by
L0_backend_identity.Caveats:
Cosmetic cleanup; no behavior change (the explicit
"BF16"string andnp_to_triton_dtype(ml_dtypes.bfloat16)resolve to the same datatype).