Skip to content

test: Move initializer_as_input ONNX test into qa/ and drop cpdir#8850

Merged
Vinya567 merged 1 commit into
mainfrom
vinyak/tri-1441-refactor-rhel-qa-build-consolidate-onnx-tests-under-serverqa
Jun 26, 2026
Merged

test: Move initializer_as_input ONNX test into qa/ and drop cpdir#8850
Vinya567 merged 1 commit into
mainfrom
vinyak/tri-1441-refactor-rhel-qa-build-consolidate-onnx-tests-under-serverqa

Conversation

@Vinya567

@Vinya567 Vinya567 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

What does the PR do?

Moves the initializer_as_input ONNX QA test from onnxruntime_backend/test/ into qa/L0_initializer_as_input/ so the test lives in the same repo where it's consumed by the QA harness (and follows the existing L0_ tier naming convention under qa/). Drops the now-redundant cpdir(onnxruntime_backend/test/*, qa/) line from cibase_build() in build.py — the files are already part of the qa/ checkout, so the cross-repo wildcard copy is unnecessary.

This addresses the [WIP] other way than wildcard? comment that was left when the cross-repo cpdir was originally introduced.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

  • test

Related PRs:

  • Follow-up PR in triton-inference-server/onnxruntime_backend to remove the now-duplicated test/initializer_as_input/ directory (will be opened after this PR merges so the source-of-truth in qa/ is live first).

Where should the reviewer start?

  1. build.py — the 3-line deletion in cibase_build() is the actual behavioral change. Confirm nothing else in that function depends on qa/ being repopulated from the backend tree.
  2. qa/L0_initializer_as_input/ — the migrated test. Files are byte-identical to the originals in onnxruntime_backend/test/initializer_as_input/; no logic changes. Diff is effectively a cross-repo directory move + L0_ prefix to match the qa/ naming convention.

Test plan:

  1. Local run of test.sh inside nvcr.io/nvidia/tritonserver:26.04-py3 with the new qa/L0_initializer_as_input/ mounted as the working directory:
    • tritonserver starts, loads add_with_initializer
    • test.py issues an inference request and verifies output
    • Result: PASS (exit code 0)
  2. CI run with the cross-repo cpdir removed and the test sourced from qa/:
    • py3-devel builds successfully (proves build.py change does not break the dev image build)
    • L0_initializer_as_input--ONNXRuntime passes, pulling files from the qa/ checkout (no cross-repo wildcard)
    • All other jobs in the gating set are green
  • CI Pipeline ID: 55844627

Caveats:

  • NVIDIA's downstream RHEL build currently copies onnxruntime_backend/test/ into qa/ at image-build time (added recently as a hotfix to unblock the RHEL pipeline). That copy becomes a no-op once this PR merges, since qa/L0_initializer_as_input/ is already in the build context. A follow-up cleanup will remove it from the downstream Dockerfile.
  • The old onnxruntime_backend/test/initializer_as_input/ directory is intentionally kept in place until this PR lands, so the existing cross-repo flow stays functional during review.

Background

The cpdir line being removed was originally added in #5630 with a [WIP] other way than wildcard? comment, flagging that the cross-repo wildcard copy was a temporary stopgap. Since qa/ is the canonical location for QA tests consumed by Triton server's QA harness, the cleanest fix is to land the test where it's consumed and drop the wildcard.

Related Issues:

N/A — no public github issue tracking this cleanup.

@Vinya567 Vinya567 added module: backends Issues related to the backends PR: test Adding missing tests or correcting existing test labels Jun 24, 2026
@Vinya567 Vinya567 force-pushed the vinyak/tri-1441-refactor-rhel-qa-build-consolidate-onnx-tests-under-serverqa branch from ed1d880 to 7fb8046 Compare June 25, 2026 17:52
@Vinya567 Vinya567 self-assigned this Jun 25, 2026
@Vinya567 Vinya567 requested review from mc-nv, whoisj and yinggeh June 25, 2026 18:07
@Vinya567 Vinya567 marked this pull request as ready for review June 25, 2026 18:08
Comment thread qa/L0_initializer_as_input/models/add_with_initializer/1/model.onnx
@Vinya567 Vinya567 force-pushed the vinyak/tri-1441-refactor-rhel-qa-build-consolidate-onnx-tests-under-serverqa branch from 7fb8046 to de2e44c Compare June 25, 2026 18:15
Comment thread qa/L0_initializer_as_input/test.sh

@whoisj whoisj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, concerned about the copyright on each file. Please address (explain or correct).

Comment thread qa/L0_initializer_as_input/models/add_with_initializer/config.pbtxt Outdated
Comment thread qa/L0_initializer_as_input/generate_test_model.py
Comment thread qa/L0_initializer_as_input/models/add_with_initializer/config.pbtxt
Comment thread qa/L0_initializer_as_input/README.md
Comment thread qa/L0_initializer_as_input/test.py
Comment thread qa/L0_initializer_as_input/test.sh
Move the initializer_as_input ONNX QA test from onnxruntime_backend/test/
into qa/L0_initializer_as_input/ so the test lives in the same repo
where it's consumed and follows the existing L0_ tier naming convention
under qa/. Drop the corresponding cpdir from cibase_build() in build.py
since the files are now part of the qa/ checkout.

This addresses the `[WIP] other way than wildcard?` comment from #5630
(which introduced the cross-repo cpdir). CI now picks up the test from
qa/ directly instead of via a cross-repo wildcard copy of
onnxruntime_backend/test/*.

A follow-up PR in triton-inference-server/onnxruntime_backend will
remove the now-duplicated test/initializer_as_input/ directory.
@Vinya567 Vinya567 force-pushed the vinyak/tri-1441-refactor-rhel-qa-build-consolidate-onnx-tests-under-serverqa branch from de2e44c to d0de154 Compare June 25, 2026 18:43
@Vinya567 Vinya567 requested review from mc-nv and whoisj June 25, 2026 19:05
@Vinya567

Copy link
Copy Markdown
Contributor Author

LGTM, concerned about the copyright on each file. Please address (explain or correct).

These aren't actually new , they're moves from onnxruntime_backend/test/initializer_as_input/ where they've existed since 2023. So the 2023 in the header is the original authorship year, and 2026 is when I moved them here.

Worth noting: the pre-commit add-license hook produced this 2023-2026 automatically when I amended ,it picks up the original year and extends to today. The tool itself follows the same pattern (its own header at tools/add_copyright.py line 1 reads "Copyright (c) 2024-2026").

Comment thread build.py
@Vinya567 Vinya567 merged commit ab68625 into main Jun 26, 2026
3 checks passed
@Vinya567 Vinya567 deleted the vinyak/tri-1441-refactor-rhel-qa-build-consolidate-onnx-tests-under-serverqa branch June 26, 2026 20:24
Vinya567 added a commit to triton-inference-server/onnxruntime_backend that referenced this pull request Jun 29, 2026
The initializer_as_input ONNX test was migrated to the upstream server
repo at qa/L0_initializer_as_input/ in
triton-inference-server/server#8850 and is no
longer consumed from this repo by any CI flow.

Companion to:
- triton-inference-server/server#8850 (merged) - upstream test move
- GitLab dl/dgx/tritonserver!1812 (merged) - yaml job rename
- GitLab dl/dgx/tritonserver!1814 (merged) - dead clone+COPY removal

With this PR, test/ becomes empty and is removed entirely. Verified
zero references exist across the triton-inference-server GitHub org.

Resolves TRI-1441
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: backends Issues related to the backends PR: test Adding missing tests or correcting existing test

Development

Successfully merging this pull request may close these issues.

4 participants