test: Move initializer_as_input ONNX test into qa/ and drop cpdir#8850
Merged
Vinya567 merged 1 commit intoJun 26, 2026
Conversation
ed1d880 to
7fb8046
Compare
mc-nv
reviewed
Jun 25, 2026
7fb8046 to
de2e44c
Compare
whoisj
reviewed
Jun 25, 2026
whoisj
requested changes
Jun 25, 2026
whoisj
left a comment
Contributor
There was a problem hiding this comment.
LGTM, concerned about the copyright on each file. Please address (explain or correct).
Move the initializer_as_input ONNX QA test from onnxruntime_backend/test/ into qa/L0_initializer_as_input/ so the test lives in the same repo where it's consumed and follows the existing L0_ tier naming convention under qa/. Drop the corresponding cpdir from cibase_build() in build.py since the files are now part of the qa/ checkout. This addresses the `[WIP] other way than wildcard?` comment from #5630 (which introduced the cross-repo cpdir). CI now picks up the test from qa/ directly instead of via a cross-repo wildcard copy of onnxruntime_backend/test/*. A follow-up PR in triton-inference-server/onnxruntime_backend will remove the now-duplicated test/initializer_as_input/ directory.
de2e44c to
d0de154
Compare
Contributor
Author
These aren't actually new , they're moves from onnxruntime_backend/test/initializer_as_input/ where they've existed since 2023. So the 2023 in the header is the original authorship year, and 2026 is when I moved them here. Worth noting: the pre-commit add-license hook produced this 2023-2026 automatically when I amended ,it picks up the original year and extends to today. The tool itself follows the same pattern (its own header at tools/add_copyright.py line 1 reads "Copyright (c) 2024-2026"). |
mc-nv
reviewed
Jun 25, 2026
whoisj
approved these changes
Jun 26, 2026
yinggeh
approved these changes
Jun 26, 2026
20 tasks
Vinya567
added a commit
to triton-inference-server/onnxruntime_backend
that referenced
this pull request
Jun 29, 2026
The initializer_as_input ONNX test was migrated to the upstream server repo at qa/L0_initializer_as_input/ in triton-inference-server/server#8850 and is no longer consumed from this repo by any CI flow. Companion to: - triton-inference-server/server#8850 (merged) - upstream test move - GitLab dl/dgx/tritonserver!1812 (merged) - yaml job rename - GitLab dl/dgx/tritonserver!1814 (merged) - dead clone+COPY removal With this PR, test/ becomes empty and is removed entirely. Verified zero references exist across the triton-inference-server GitHub org. Resolves TRI-1441
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Moves the
initializer_as_inputONNX QA test fromonnxruntime_backend/test/intoqa/L0_initializer_as_input/so the test lives in the same repo where it's consumed by the QA harness (and follows the existingL0_tier naming convention underqa/). Drops the now-redundantcpdir(onnxruntime_backend/test/*, qa/)line fromcibase_build()inbuild.py— the files are already part of theqa/checkout, so the cross-repo wildcard copy is unnecessary.This addresses the
[WIP] other way than wildcard?comment that was left when the cross-repocpdirwas originally introduced.Checklist
<commit_type>: <Title>Commit Type:
Related PRs:
triton-inference-server/onnxruntime_backendto remove the now-duplicatedtest/initializer_as_input/directory (will be opened after this PR merges so the source-of-truth inqa/is live first).Where should the reviewer start?
build.py— the 3-line deletion incibase_build()is the actual behavioral change. Confirm nothing else in that function depends onqa/being repopulated from the backend tree.qa/L0_initializer_as_input/— the migrated test. Files are byte-identical to the originals inonnxruntime_backend/test/initializer_as_input/; no logic changes. Diff is effectively a cross-repo directory move +L0_prefix to match theqa/naming convention.Test plan:
test.shinsidenvcr.io/nvidia/tritonserver:26.04-py3with the newqa/L0_initializer_as_input/mounted as the working directory:tritonserverstarts, loadsadd_with_initializertest.pyissues an inference request and verifies outputPASS(exit code 0)cpdirremoved and the test sourced fromqa/:py3-develbuilds successfully (provesbuild.pychange does not break the dev image build)L0_initializer_as_input--ONNXRuntimepasses, pulling files from theqa/checkout (no cross-repo wildcard)Caveats:
onnxruntime_backend/test/intoqa/at image-build time (added recently as a hotfix to unblock the RHEL pipeline). That copy becomes a no-op once this PR merges, sinceqa/L0_initializer_as_input/is already in the build context. A follow-up cleanup will remove it from the downstream Dockerfile.onnxruntime_backend/test/initializer_as_input/directory is intentionally kept in place until this PR lands, so the existing cross-repo flow stays functional during review.Background
The
cpdirline being removed was originally added in #5630 with a[WIP] other way than wildcard?comment, flagging that the cross-repo wildcard copy was a temporary stopgap. Sinceqa/is the canonical location for QA tests consumed by Triton server's QA harness, the cleanest fix is to land the test where it's consumed and drop the wildcard.Related Issues:
N/A — no public github issue tracking this cleanup.