Skip to content

test: Add Dynamo launch mode to L0_infer#8851

Merged
yinggeh merged 1 commit into
mainfrom
yinggeh/tri-1457-setup-l0_infer-automation
Jun 24, 2026
Merged

test: Add Dynamo launch mode to L0_infer#8851
yinggeh merged 1 commit into
mainfrom
yinggeh/tri-1457-setup-l0_infer-automation

Conversation

@yinggeh

@yinggeh yinggeh commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

What does the PR do?

Adds a SERVER_LAUNCH_MODE=dynamo path to the L0_infer test so it can run Triton through the Dynamo frontend (KServe gRPC) plus an in-process Triton worker, backed by etcd + NATS discovery, instead of the standalone tritonserver binary.

  • New qa/common/dynamo_util.sh: sourced in place of util.sh when SERVER_LAUNCH_MODE=dynamo. Overrides run_server/kill_server to launch the Dynamo frontend + Triton worker, bring up etcd + NATS (binaries shipped in the Dynamo container), translate SERVER_ARGS into worker flags, and wait until all models in the repository are ready.
  • qa/L0_infer/test.sh: selects the launch mode and sources the matching util script.
  • qa/L0_infer/infer_test.py: skips cases that exercise KServe features the Dynamo gRPC path does not yet support (FP16/BF16 tensors, classification output, model version selection) and disables HTTP-client paths (the Dynamo frontend exposes only KServe gRPC).
  • qa/common/infer_util.py, qa/common/shm_util.py: guard the tritonclient.http import behind non-dynamo mode.

The default (triton) path is unchanged.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

  • test

Related PRs:

Where should the reviewer start?

Test plan:

  • Default mode unchanged: qa/L0_infer/test.sh with SERVER_LAUNCH_MODE unset/triton.

  • Dynamo mode: run inside the Dynamo Triton container with SERVER_LAUNCH_MODE=dynamo; frontend + worker come up against etcd + NATS, all models report ready, and the supported subset of L0_infer passes (FP16/classification/version cases skipped).

  • CI Pipeline ID: 55686086

Caveats:

Background

Enables L0_infer to validate the Dynamo Triton backend frontend/worker path alongside the standalone server.

Related Issues:

N/A

Add a SERVER_LAUNCH_MODE=dynamo path that runs L0_infer through the Dynamo
frontend (KServe gRPC) plus an in-process Triton worker, backed by etcd + NATS
discovery. Skips test cases that exercise KServe features the Dynamo gRPC path
does not yet support (FP16/BF16, classification output, model version
selection) and disables the HTTP client paths the Dynamo frontend does not
expose.
@yinggeh yinggeh self-assigned this Jun 24, 2026
@yinggeh yinggeh requested review from Vinya567, mudit-eng and whoisj June 24, 2026 13:12
@yinggeh yinggeh added the PR: test Adding missing tests or correcting existing test label Jun 24, 2026
@yinggeh yinggeh merged commit 80c18a6 into main Jun 24, 2026
3 checks passed
@yinggeh yinggeh deleted the yinggeh/tri-1457-setup-l0_infer-automation branch June 24, 2026 21:28
@mudit-eng

Copy link
Copy Markdown
Contributor

@yinggeh, @whoisj, @Vinya567 - Not related to this PR, but how about enabling a code review tool? I remember seeing coderabbit reviewing some of Triton PRs, but I don't see it anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: test Adding missing tests or correcting existing test

Development

Successfully merging this pull request may close these issues.

3 participants