fix: re-enable Torch-TensorRT model generation for SM 12.1#8860
Merged
Conversation
mc-nv
previously approved these changes
Jun 26, 2026
whoisj
previously approved these changes
Jun 26, 2026
yinggeh
reviewed
Jun 26, 2026
yinggeh
requested changes
Jun 26, 2026
whoisj
approved these changes
Jun 26, 2026
yinggeh
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Re-enables Torch-TensorRT QA model generation on devices with compute capability
12.1 (NVIDIA GB10 / DGX Spark) by removing a temporary skip in
qa/common/gen_qa_model_repositorythat was added when TensorRT lacked therequired convolution kernels for SM 12.1.
The skip is no longer needed: TensorRT 10.16.1.11 (shipped in the current
pytorch:26.05 base image) generates the required kernels successfully, so
torchtrt_model_store/resnet50_libtorch/1/model.ptbuilds end-to-end on realGB10 hardware. Without this change the downstream test
L0_libtorch_torchtrt_image_models--PyTorch--DGX-Sparkfails because themodel store is empty.
Checklist
<commit_type>: <Title>Commit Type:
Related PRs:
allow_failure: truefrom the DGX Spark L0 test once a master nightlyconfirms it is green.
Where should the reviewer start?
qa/common/gen_qa_model_repository— single-line change removing thenvidia-smi --query-gpu=compute_cap | grep -qz 12.1 && echo WARNING || ...guard that previously skipped Torch-TRT model generation on SM 12.1.
Test plan:
gen_qa_torchtrt_models.pyproduces a validresnet50_libtorch/1/model.pt.L0_libtorch_torchtrt_image_models--PyTorch--DGX-Sparkend-to-end on the same hardware against the freshly generated model store.
resnet50_libtorch,image_client.pyproduced theexpected classification, test output:
*** Test Passed ***.Caveats:
(the guard only matched 12.1).
GenModels-buildjob's behavior changes (from"skip with warning" to "build"); the only downstream consumer of the
generated artifact is
L0_libtorch_torchtrt_image_models.Background
The SM 12.1 skip was introduced as a temporary workaround for an upstream
TensorRT kernel gap on Blackwell GB10. That gap has since been resolved in
the TensorRT version pulled by the current PyTorch container, so the
workaround is no longer needed.
Related Issues: