libmdnsd: guard NULL decoded names in _cache() - #97
Merged
Conversation
troglobit
requested changes
Jul 24, 2026
troglobit
left a comment
troglobit
left a comment
Owner
There was a problem hiding this comment.
Two minor changes that make the code slightly cleaner and matches project style.
Malformed name and SRV records can leave their decoded target name NULL. _cache() passes these names to strdup(), causing a remotely reachable null-pointer dereference. Reject these records and release the partially allocated cache entry. Signed-off-by: Julius Pfrommer <julius.pfrommer@o6-automation.com>
Contributor
Author
|
Done |
Owner
Perfect, thanks! New release in a few days 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Malformed name and SRV records can leave their decoded target name NULL. _cache() passes these names to strdup(), causing a remotely reachable null-pointer dereference.
Reject these records and release the partially allocated cache entry.