Skip to content

NAS-139272 / 25.10.2 / fix: ACL form reported invalid even when valid user/group selected - #13129

Merged
william-gr merged 3 commits into
stable/goldeyefrom
NAS-139272
Jan 20, 2026
Merged

NAS-139272 / 25.10.2 / fix: ACL form reported invalid even when valid user/group selected#13129
william-gr merged 3 commits into
stable/goldeyefrom
NAS-139272

Conversation

@aervin

@aervin aervin commented Jan 19, 2026

Copy link
Copy Markdown
Contributor

Testing:
See ticket
Add new entries to ACLs and verify validation states are correct

@bugclerk

Copy link
Copy Markdown
Contributor

@bugclerk bugclerk changed the title fix: ACL form reported invalid even when valid user/group selected NAS-139272 / 25.10.2 / fix: ACL form reported invalid even when valid user/group selected Jan 19, 2026
@aervin

aervin commented Jan 19, 2026

Copy link
Copy Markdown
Contributor Author

time 2:00

@aervin

aervin commented Jan 19, 2026

Copy link
Copy Markdown
Contributor Author

backport

@bugclerk

Copy link
Copy Markdown
Contributor

Unable to backport to 26.04:

  File "/home/bugclerk/bugclerk/services/github_service.py", line 972, in backport_pull_request
    subprocess.check_call(['git', 'commit', '--allow-empty', '-m',
    ~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                           'Empty commit to create PR on github.\n' +
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                           '\nYou should reset it'], cwd=cwd)
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.13/subprocess.py", line 419, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['git', 'commit', '--allow-empty', '-m', 'Empty commit to create PR on github.\n\nYou should reset it']' returned non-zero exit status 128.

@bugclerk

Copy link
Copy Markdown
Contributor

Unable to perform the following backports: backport-26.04.
Available versions: 13.0, 13.3, 24.10.2.2, 24.10.2.4, 24.10.3, 25.04.0, 25.04.1, 25.04.2.5, 25.04.2.6, 25.04.2.7, 25.04.3, 25.10-BETA.1, 25.10-RC.1, 25.10.0, 25.10.0.1, 25.10.1, 25.10.2, 26.04.

@codecov

codecov Bot commented Jan 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (stable/goldeye@ed81660). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../components/edit-nfs-ace/edit-nfs-ace.component.ts 90.90% 1 Missing ⚠️
...ponents/edit-posix-ace/edit-posix-ace.component.ts 90.90% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             stable/goldeye   #13129   +/-   ##
=================================================
  Coverage                  ?   86.18%           
=================================================
  Files                     ?     1831           
  Lines                     ?    67529           
  Branches                  ?     8105           
=================================================
  Hits                      ?    58201           
  Misses                    ?     9328           
  Partials                  ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aervin
aervin marked this pull request as ready for review January 19, 2026 18:45
@william-gr

Copy link
Copy Markdown
Member

backport

@william-gr william-gr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described

@AlexKarpov98 AlexKarpov98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@william-gr
william-gr merged commit 1ea559c into stable/goldeye Jan 20, 2026
14 checks passed
@william-gr
william-gr deleted the NAS-139272 branch January 20, 2026 11:48
@bugclerk

Copy link
Copy Markdown
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants