Skip to content

NAS-139471 / 25.10.3 / Smb share configuration cannot be edited after upgrade from Fangtooth (25.04.2.6) to Goldeye (25.10.2) when audit log is enabled - #13166

Merged
william-gr merged 1 commit into
stable/goldeyefrom
NAS-139471
Jan 28, 2026
Merged

Conversation

@AlexKarpov98

Copy link
Copy Markdown
Contributor

Testing:
see ticket.

Preview:

Screen.Recording.2026-01-27.at.22.58.57.mov

…om Fangtooth (25.04.2.6) to Goldeye (25.10.2) when audit log is enabled
@AlexKarpov98 AlexKarpov98 self-assigned this Jan 28, 2026
@bugclerk bugclerk changed the title NAS-139471: Smb share configuration cannot be edited after upgrade from Fangtooth (25.04.2.6) to Goldeye (25.10.2) when audit log is enabled NAS-139471 / 25.10.3 / Smb share configuration cannot be edited after upgrade from Fangtooth (25.04.2.6) to Goldeye (25.10.2) when audit log is enabled Jan 28, 2026
@bugclerk

Copy link
Copy Markdown
Contributor

@AlexKarpov98
AlexKarpov98 marked this pull request as ready for review January 28, 2026 11:39
@codecov

codecov Bot commented Jan 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.24390% with 4 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (stable/goldeye@2bd2bd1). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...p/pages/sharing/smb/smb-form/smb-form.component.ts 90.24% 4 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             stable/goldeye   #13166   +/-   ##
=================================================
  Coverage                  ?   86.18%           
=================================================
  Files                     ?     1831           
  Lines                     ?    67600           
  Branches                  ?     8119           
=================================================
  Hits                      ?    58259           
  Misses                    ?     9341           
  Partials                  ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bugclerk

Copy link
Copy Markdown
Contributor

JIRA ticket https://ixsystems.atlassian.net/browse/NAS-139471 is targeted to the following versions which have not received their corresponding PRs: 25.10.2

@bugclerk

Copy link
Copy Markdown
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 28, 2026
@william-gr

Copy link
Copy Markdown
Member

backport

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants