Skip to content

NAS-141590 / 25.10.5 / Hide deduplication on zvol form when enterprise without dedup license (by william-gr) (by bugclerk) - #13765

Merged
william-gr merged 1 commit into
release/25.10.5from
NAS-141590-25.10.5
Jul 2, 2026
Merged

NAS-141590 / 25.10.5 / Hide deduplication on zvol form when enterprise without dedup license (by william-gr) (by bugclerk)#13765
william-gr merged 1 commit into
release/25.10.5from
NAS-141590-25.10.5

Conversation

@bugclerk

@bugclerk bugclerk commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Original PR: #13746

Original PR: #13751

@bugclerk

bugclerk commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x 419b9c7e126d23745ea1530087b7a12c9bc5d228

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x 5f7dd0d0a3c1e403c849b7006326a0627082bb58

@bugclerk bugclerk self-assigned this Jul 2, 2026
@bugclerk

bugclerk commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Jira URL: https://ixsystems.atlassian.net/browse/NAS-141590

@bugclerk @william-gr
NAS-141590: Hide deduplication on zvol form when enterprise without d…
2bfcf12 
…edup license (#13751)

Co-authored-by: William Grzybowski <56250+william-gr@users.noreply.github.com>
(cherry picked from commit 5f7dd0d)
@william-gr
william-gr force-pushed the NAS-141590-25.10.5 branch from 666adcd to 2bfcf12 Compare July 2, 2026 14:02
@william-gr
william-gr marked this pull request as ready for review July 2, 2026 14:09
@codecov

codecov Bot commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release/25.10.5@1d3f872). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...tasets/components/zvol-form/zvol-form.component.ts 94.73% 1 Missing ⚠️
Additional details and impacted files 
@@                Coverage Diff                 @@
##             release/25.10.5   #13765   +/-   ##
==================================================
  Coverage                   ?   61.32%           
==================================================
  Files                      ?     1833           
  Lines                      ?    67754           
  Branches                   ?     8151           
==================================================
  Hits                       ?    41552           
  Misses                     ?    26202           
  Partials                   ?        0

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@william-gr
william-gr merged commit c51dc51 into release/25.10.5 Jul 2, 2026
12 of 13 checks passed
@william-gr
william-gr deleted the NAS-141590-25.10.5 branch July 2, 2026 14:54
@bugclerk

bugclerk commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jul 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@william-gr william-gr william-gr approved these changes

Assignees

@bugclerk bugclerk

Labels

no-time-tracked

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bugclerk @william-gr