Skip to content

Hide locationless schematic simulation text - #53

Open
ShiboSoftwareDev wants to merge 1 commit into
mainfrom
codex/hide-locationless-schematic-text
Open

Hide locationless schematic simulation text#53
ShiboSoftwareDev wants to merge 1 commit into
mainfrom
codex/hide-locationless-schematic-text

Conversation

@ShiboSoftwareDev

Copy link
Copy Markdown
Contributor

What changed

The converter now uses the AltiumTS fix from tscircuit/altiumts#84 and updates the two affected HERON schematic snapshots.

Why

Some Altium simulation settings are stored as text parameter records without a position. AltiumTS previously gave those records a made-up (0, 0) position, causing several unrelated simulation strings to appear on top of each other at the lower-left of both the source and converted views.

The AltiumTS fix skips text that has no source position. The converter itself does not need special handling: pinning the renderer fix removes the false text from both panes while keeping all positioned schematic text unchanged.

Visual verification

  • HERON PAY-SSM: the simulation-text pile disappears from the lower edge in both source and converted views.
  • HERON Systems PCB: the same false lower-edge text disappears from both views.
  • Both snapshots were regenerated directly by Bun's SVG snapshot matcher.

Testing

  • bun test --max-concurrency=1 — 52 passed, 0 failed
  • bun run format:check
  • bun run typecheck

Depends on tscircuit/altiumts#84.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant