Fix schematic text sizes in real Altium viewers - #94
Open
techmannih wants to merge 6 commits into
Open
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
After
Summary
Real Altium viewers rendered exported schematic annotations much larger than intended when fractional font-table values such as
SIZE=3.6were interpreted inconsistently. Native pin records also need their dedicated custom-font fields.This PR preserves the existing text sizes that were already correct, rounds generated font-table entries to whole points, and applies category-specific font IDs so the problematic text matches its intended reference text.
Text sizing relationships
R1,R2, etc.).NAME_CUSTOMFONTIDandDESIGNATOR_CUSTOMFONTID.For example, the Rearview Mirror export now writes
R21,0Ω,U6, andTCAN1042HGVDRBQ1at the same 4 pt size. ItsCANHpin label, pin number, and inline trace label all use the same 3 pt font entry.Regression coverage
SIZE*field is a whole-point value.Verification
bun test— 77 passed, 0 failedbun run typecheck— passedbun run format:check— passedgit diff --check— passedNo generated Altium ZIP or other binary artifact is included in this PR.