fix(schematic): skip junction dots for different-net T-junctions (#2553)#2556
Open
rovidev95 wants to merge 3 commits into
Open
fix(schematic): skip junction dots for different-net T-junctions (#2553)#2556rovidev95 wants to merge 3 commits into
rovidev95 wants to merge 3 commits into
Conversation
…ircuit#2553) Endpoint junction logic in computeJunctions only applies within the same connectivity_key. Different nets crossing at a T still get is_crossing segments from computeCrossings, but no longer show a shared junction dot that implies they are electrically connected. Adds focused unit tests for same-net vs different-net T-junctions. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Open
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2553
Different nets that meet at a T-junction were incorrectly getting schematic junction dots, making them look electrically connected.
computeJunctionsnow only creates endpoint junctions when both traces share the sameconnectivity_key. Crossings between different nets continue to be handled bycomputeCrossings()(is_crossingsegments) without junction dots.Changes
compute-junctions.ts: restrict endpoint junction blocks to same-net pairscompute-junctions.test.ts: regression tests for same-net vs different-net T-junctionsVerification
/attempt #2553