Skip to content

fix(schematic): resolve netlabel net connections to the net's ports (floating power net label) #2559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chayan-1906 wants to merge 1 commit into
base: main
Choose a base branch
from
+136 −3
Open

fix(schematic): resolve netlabel net connections to the net's ports (floating power net label) #2559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions lib/components/primitive-components/NetLabel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,17 @@ export class NetLabel extends PrimitiveComponent<typeof netLabelProps> {

const connectedPorts: Port[] = []
for (const connection of connectsTo) {
const port = this.getSubcircuit().selectOne(connection) as Port
if (port) {
connectedPorts.push(port)
const target = this.getSubcircuit().selectOne(connection)
if (!target) continue

// A net selector (e.g. "net.C") resolves to a Net, which has no port
// position of its own - use the ports connected to that net instead
if (target instanceof Net) {
connectedPorts.push(...target.getAllConnectedPorts())
continue
}

connectedPorts.push(target as Port)
}

return connectedPorts
Expand Down
Loading
Loading