fix: manual edits inside positioned group should use absolute manual center

[r-audio]

Problem

When a component is placed via manualEdits with relative_to: "group_center" inside a <group> that has pcbX/pcbY offsets, the parent group's transform is applied twice — once inside _getPcbManualPlacementForComponent() (which already returns the absolute PCB center) and again when composing with this.parent?._computePcbGlobalTransformBeforeLayout().

This causes components to land at parent_offset + manual_placement instead of the intended absolute position.

Reproduction: placing a capacitor at { x: 11.4, y: 4.3 } inside a group with pcbX=16 yields x=27.4 instead of x=11.4.

Fix

Remove the parent transform composition from _computePcbGlobalTransformBeforeLayout() when manual placement is active. The manual placement already returns absolute coordinates, so the parent transform should not be re-applied.

- this.parent?._computePcbGlobalTransformBeforeLayout() ?? identity(),
- compose(
-   translate(manualPlacement.x, manualPlacement.y),
-   rotate((rotation * Math.PI) / 180),
- ),
+ translate(manualPlacement.x, manualPlacement.y),
+ rotate((rotation * Math.PI) / 180),

Verification

bun test \
  tests/components/normal-components/manual-placement-conflicts.test.tsx \
  tests/components/normal-components/manual-edit-conflict-warning-2.test.tsx \
  tests/components/normal-components/board-layout.test.tsx \
  tests/components/primitive-components/group-anchor-position.test.tsx

Result: 9 pass, 0 fail (1 snapshot, 22 expect() calls)

New test manual layout edits inside positioned group use absolute manual center verifies the fix directly by asserting the capacitor lands at the intended (11.4, 4.3) position.

Fixes #2281

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
tscircuit-core-benchmarks	Ready	Preview, Comment	Jul 3, 2026 12:15am

[github-actions]

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.