Preserve targeted repair in safe trace branch - #54
Draft
ShiboSoftwareDev wants to merge 1 commit into
Draft
Conversation
Benchmark This PRRun benchmarks by commenting on this PR: Everything after Examples:
Any PR whose title contains |
Contributor
Author
|
Production validation in tscircuit/tscircuit-autorouter#1934 shows no effect on the affected boards: Dataset 18 sample 8 remains at 24 DRC errors with four via-clearance errors, and Dataset 24 sample 2 remains at 75 DRC errors with two via-clearance errors. This PR should not be treated as the benchmark root fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The safe trace-layer branch copied the portfolio options and then forced
enableTargetedErrorSweepoff. That prevented the existing exact same-net via repair from cleaning up a via violation created while resolving trace collisions.Implementation
Remove that override so the branch honors the caller setting. With targeted repair enabled, the existing same-net via canonicalization runs before the branch finishes. No solver or fallback is added.
The reproduction snapshot changes from one
pcb_via_clearance_errorto no DRC errors.Stacked on #53.
Checks