Reproduce discarded safe-layer DRC improvement - #61
Draft
ShiboSoftwareDev wants to merge 1 commit into
Draft
Conversation
Benchmark This PRRun benchmarks by commenting on this PR: Everything after Examples:
Any PR whose title contains |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The safe trace-layer phase can reduce the exact DRC count, but the portfolio discards the candidate unless it removes every trace and pad error.
Reproduction
The snapshot shows the failure directly: the input has 4 DRC errors, the safe-layer candidate has 1, and the portfolio still returns the 4-error input.
This PR contains only the focused test and its SVG snapshot.
Checks
bun test tests/safe-trace-layer-move.test.tsbun run formatcheckbun run typecheck