Keep safe-layer DRC improvements - #62
Draft
ShiboSoftwareDev wants to merge 1 commit into
Draft
Conversation
Benchmark This PRRun benchmarks by commenting on this PR: Everything after Examples:
Any PR whose title contains |
imrishabh18
changed the base branch from
agent/repro-partial-safe-trace-acceptance
to
main
August 20, 2026 13:02
imrishabh18
force-pushed
the
agent/fix-partial-safe-trace-acceptance
branch
from
August 20, 2026 13:08
8565af9 to
c464c93
Compare
imrishabh18
changed the base branch from
main
to
agent/repro-partial-safe-trace-acceptance
August 20, 2026 13:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The portfolio rejects a safe trace-layer candidate whenever any trace or pad error remains, even when exact DRC shows that the candidate is a strict improvement.
Implementation
Accept the candidate when the existing exact DRC comparison says it is better and its via-related DRC count did not increase.
The same snapshot now shows 4 DRC errors at the input, 1 in the candidate, and 1 in the portfolio output.
Checks
bun test(55 passed)bun run formatcheckbun run typecheck