Add pcbComb trace prop#715
Open
derekbreden wants to merge 1 commit into
Open
Conversation
A sibling to pcbStraightLine/pcbPath: a fixed straight → 45° → straight comb route between two lines of pads, selected by orientation (columnToColumn | rowToColumn | columnToRow | rowToRow). Schema only; the geometry is computed in @tscircuit/core's manual-trace phase.
derekbreden
added a commit
to derekbreden/props
that referenced
this pull request
Jul 4, 2026
…cuit#715) Adopts the PR's exact prop name and description so the board dogfoods the upstreamed API rather than the workbench's pre-PR pcbFan spelling. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
derekbreden
added a commit
to derekbreden/homesodamachine
that referenced
this pull request
Jul 4, 2026
The board and forks carried this feature under its pre-PR name pcbFan; the extracted PRs name it pcbComb (tscircuit/core#2567, tscircuit/props#715). Rename the core+props forks to pcbComb — adopting the PRs' exact util and prop verbatim (same algorithm, only names/comments differ) — bump the override SHAs, and switch every pcba.tsx trace plus the docs to pcbComb. Pure rename: the rendered copper is byte-identical, so out/ is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
pcbCombfield totraceProps— a sibling topcbStraightLine/pcbPathfor a fixed, manually-shaped trace between two lines of pads. The value is an orientation:columnToColumn | rowToColumn | columnToRow | rowToRow.Schema only. The geometry — a perpendicular escape → 45° diagonal → perpendicular landing, so a bundle nests into an even comb — is implemented in the companion core PR tscircuit/core#2567, which carries the context, a worked visual example, and (honestly) our uncertainty about how common the case is.
Offered for your consideration.