Skip to content

CPAN compliant and TAP compliant 馃巵 - #404

Open
lskatz wants to merge 5 commits into
tseemann:masterfrom
lskatz:master
Open

CPAN compliant and TAP compliant 馃巵#404
lskatz wants to merge 5 commits into
tseemann:masterfrom
lskatz:master

Conversation

@lskatz

@lskatz lskatz commented Aug 8, 2019

Copy link
Copy Markdown

I created a Makefile.PL so that Prokka is CPAN-compliant. This also makes things more streamlined in Travis-CI.

  • Added minimal documentation in prokka.
  • Added Makefile.PL which describes modules used among many other things.
  • Added MANIFEST for make dist, if you decide to upload to cpan.
  • Moved tests to t/05_prokka.t which is invoked with make test or perl t/05_prokka.t.
    • Any future unit tests can be created in t/ and will be run in alphanumeric order. I chose to start the unit test script with 05 in case there were a future test that should be run before this one.
  • Replaced one instance of sed with pure perl to help with error checking and/or any issues with subshells at that stage.

All tests defined by @tseemann pass in travis-ci.

@mr-c

mr-c commented Dec 15, 2019

Copy link
Copy Markdown

Would be great to see Prokka in CPAN!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants