[Self-review] Hosts monitor page (#2292)#1
Closed
ttpss930141011 wants to merge 6 commits into
Closed
Conversation
ttpss930141011
force-pushed
the
dev-days/2292-hosts-monitor-page
branch
2 times, most recently
from
dbe0b55 to
836cfa7
Compare
…ademySoftwareFoundation#2292) Add an isHostsTable flag (mirroring isFramesTable / isFramesLogTable) so the read-only hosts page can reuse SimpleDataTable: host-specific filter placeholder and empty-state copy, and no row context menu. Defaults to false, so existing frames/layers callers are unchanged.
ttpss930141011
force-pushed
the
dev-days/2292-hosts-monitor-page
branch
from
836cfa7 to
189942b
Compare
Owner
Author
|
Self-review done; opened the real PR against upstream (AcademySoftwareFoundation#2391). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-review PR (fork-internal)
This PR is for self-review on my own fork before opening against
AcademySoftwareFoundation/OpenCue. Implements AcademySoftwareFoundation#2292 (Hosts monitor page).What this change does
Adds the
/hostsroute — a Monitor Hosts page for CueWeb (web equivalent of CueGUI's CueCommander → Monitor Hosts). CueWeb previously had no hosts page (the sidebar/hostslink 404'd)./hostspage: loads hosts viagetHosts(), auto-refreshes every 30s.Statusbadge.Hosttype widened; small KB-string parse/format helpers with unit tests.SimpleDataTablegains 3 backward-compatible optional props (disableContextMenu,filterPlaceholder,emptyState) so a read-only table can reuse it. Existing jobs/layers/frames callers unchanged (full suite 48/48 passes).Self-review checklist
SimpleDataTablechange is backward-compatible (no jobs/layers/frames regression)AcademySoftwareFoundation/OpenCue:masterScope
Read-only by design. Host actions (lock/tag/reboot/NIMBY) and server-side filtering are sibling issues (AcademySoftwareFoundation#2293–AcademySoftwareFoundation#2296), out of scope here.