test(repro): skip repro-flow-execute when local session file is absent#37
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tests/repro-flow-execute.test.tsrelies on a hardcoded session fixture path that only exists on one developer's machine:When CI (or anyone else) runs
npm test, the file is missing and the suite fails with:Fix
Make the repro test conditional on the fixture being present:
The test still runs locally when
PI_REPRO_SESSIONpoints at an existing file, but it no longer breaks CI or other contributors' machines.Scope
This is a CI hygiene fix. It is split out from #36 so that PR can remain focused on the
withFileMutationQueueinstall fix.Suggested merge order: merge this PR first, then #36 will pass CI cleanly.