test(repro): make repro-flow-execute self-contained#38
Merged
Conversation
Replace the skip-when-missing fix with an in-memory default session fallback. The repro test now runs in CI instead of being skipped, while still using the original fixture when PI_REPRO_SESSION points at an existing file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#37 skipped
tests/repro-flow-execute.test.tswhen its local session fixture was absent. That fixed CI, but it also meant the repro test was never exercised in CI — it only ran on the one machine that still had the original fixture.Fix
Replace the skip with a self-contained in-memory default session. The test now:
PI_REPRO_SESSIONpoints at an existing file, andThis keeps the repro runnable in CI while preserving the ability to replay the original captured session locally.
Verification
npm test— 1916 passed, 0 skipped (the repro test now runs and passes with the default session).npx vitest run tests/repro-flow-execute.test.tspasses.Scope
This is a follow-up to #37. It supersedes the skip by making the test self-contained.