-
Notifications
You must be signed in to change notification settings - Fork 830
core/vdbe: Short-circuit index seek on NULL keys in LEFT JOIN #6268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
friskypriyanshu
wants to merge
4
commits into
tursodatabase:main
Choose a base branch
from
friskypriyanshu:fix/left-join-null-index
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+44
−0
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c4e27a4
fix: short-circuit index seek on NULL keys in LEFT JOIN (#6077)
friskypriyanshu 9e4f19f
style: run cargo fmt and fix clippy warnings
friskypriyanshu 31385cf
fix: restrict NULL short-circuit to equality seeks
friskypriyanshu 245d6ef
fix: resolve clippy lints and revert test-runner box
friskypriyanshu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
testing/sqltests/tests/joins/left_join_null_index_bug.sqltest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| @database :memory: | ||
|
|
||
| test left-join-null-index-bug { | ||
| CREATE TABLE a(id INTEGER PRIMARY KEY); | ||
| CREATE TABLE b(id INTEGER PRIMARY KEY, a_id INTEGER); | ||
| CREATE TABLE c(id INTEGER PRIMARY KEY, b_id INTEGER); | ||
|
|
||
| INSERT INTO a VALUES (1),(2); | ||
| INSERT INTO b VALUES (1,1); | ||
| INSERT INTO c VALUES (1,NULL); | ||
|
|
||
| CREATE INDEX idx_c_bid ON c(b_id); | ||
|
|
||
| SELECT a.id, b.id AS bid, c.id AS cid | ||
| FROM a | ||
| LEFT JOIN b ON a.id = b.a_id | ||
| LEFT JOIN c ON b.id = c.b_id | ||
| ORDER BY a.id; | ||
| } | ||
| expect { | ||
| 1|1| | ||
| 2|| | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use
target_pc.as_offset_int()here which has equivalent behavior